Skip to content

Carry the short-pool guard to the Wikidata corpus builder - #697

Merged
derek73 merged 3 commits into
masterfrom
fix/issue-696-short-pool-guard
Oct 17, 2026
Merged

derek73 merged 3 commits into
masterfrom
fix/issue-696-short-pool-guard

Conversation

@derek73

@derek73 derek73 commented Oct 17, 2026

Copy link
Copy Markdown
Owner

Part of #696 (items 1 and 2; item 3, the shared stratum driver and `fetch_bytes`, is left open).

  • `pooled()` in `build_wikidata_corpus.py` now holds the pool fetch and both size checks (short pool, stale `whole` mark). Both Wikidata builders call it; the native builder's copy is gone.
  • The parent's `Stratum` gains `whole` and a `size` property.
  • Re-pooled the parent's strata against live WDQS on 2026-10-16 (scratch cache): Iceland matched 270 of 600 and Malaysia 17 of 240, so both are marked whole; the other six filled their pools.
  • Offline rebuilds of both corpora leave every committed file unchanged.
  • Tests: two new parent tests mirroring the native ones; the cache tests serve a full-size pool. ruff, mypy and the corpus/doc tests pass.

Refs #696

🤖 Generated with Claude Code

Move the pool fetch and both size checks into pooled() in
build_wikidata_corpus.py; both Wikidata builders call it. Mark the
parent's Iceland (270 of 600) and Malaysia (17 of 240) strata whole,
from a live re-pool on 2026-10-16; the other six filled their pools.
Offline rebuilds of both corpora are byte-identical.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@derek73 derek73 self-assigned this Oct 17, 2026
…IMIT, fix stale prose (#696)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.03%. Comparing base (587b04e) to head (a507459).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #697   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files          46       46           
  Lines        4541     4541           
=======================================
  Hits         4497     4497           
  Misses         44       44           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…econd review (#696)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@derek73
derek73 merged commit 9e7b728 into master Oct 17, 2026
12 checks passed
@derek73
derek73 deleted the fix/issue-696-short-pool-guard branch October 17, 2026 09:47
@derek73 derek73 added this to the 2.5 milestone Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant